Skip to content

Commit

Permalink
tools: pynl: make flags argument optional for do()
Browse files Browse the repository at this point in the history
Commit 1768d8a ("tools/net/ynl: Add support for create flags")
added support for setting legacy netlink CRUD flags on netlink
messages (NLM_F_REPLACE, _EXCL, _CREATE etc.).

Most of genetlink won't need these, don't force callers to pass
in an empty argument to each do() call.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://lore.kernel.org/r/20231202211005.341613-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed Dec 6, 2023
1 parent bce4934 commit e136735
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/net/ynl/lib/ynl.py
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ def operation_do_attributes(self, name):

return op['do']['request']['attributes'].copy()

def _op(self, method, vals, flags, dump=False):
def _op(self, method, vals, flags=None, dump=False):
op = self.ops[method]

nl_flags = Netlink.NLM_F_REQUEST | Netlink.NLM_F_ACK
Expand Down Expand Up @@ -769,7 +769,7 @@ def _op(self, method, vals, flags, dump=False):
return rsp[0]
return rsp

def do(self, method, vals, flags):
def do(self, method, vals, flags=None):
return self._op(method, vals, flags)

def dump(self, method, vals):
Expand Down

0 comments on commit e136735

Please sign in to comment.