Skip to content

Commit

Permalink
c6x: Replace setup_irq() by request_irq()
Browse files Browse the repository at this point in the history
request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

setup_irq() was required in older kernels as the memory allocator was not
available during early boot.

Hence replace setup_irq() by request_irq().

Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/56e991e920ce5806771fab892574cba89a3d413f.1585320721.git.afzal.mohd.ma@gmail.com
  • Loading branch information
afzal mohammed authored and Thomas Gleixner committed Mar 29, 2020
1 parent 82c849e commit e13b99f
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions arch/c6x/platforms/timer64.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}

static struct irqaction timer_iact = {
.name = "timer",
.flags = IRQF_TIMER,
.handler = timer_interrupt,
.dev_id = &t64_clockevent_device,
};

void __init timer64_init(void)
{
struct clock_event_device *cd = &t64_clockevent_device;
Expand Down Expand Up @@ -238,7 +231,9 @@ void __init timer64_init(void)
cd->cpumask = cpumask_of(smp_processor_id());

clockevents_register_device(cd);
setup_irq(cd->irq, &timer_iact);
if (request_irq(cd->irq, timer_interrupt, IRQF_TIMER, "timer",
&t64_clockevent_device))
pr_err("Failed to request irq %d (timer)\n", cd->irq);

out:
of_node_put(np);
Expand Down

0 comments on commit e13b99f

Please sign in to comment.