Skip to content

Commit

Permalink
n_gsm: introduce enum gsm_dlci_mode
Browse files Browse the repository at this point in the history
gsm_dlci->mode is clearly an enumeration. So introduce one and use it
-- compiler now checks if valid values are assigned to the field.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200219084949.28074-3-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Feb 19, 2020
1 parent 72ae8cc commit e178599
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/tty/n_gsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ enum gsm_dlci_state {
DLCI_CLOSING, /* Sending DISC not seen UA/DM */
};

enum gsm_dlci_mode {
DLCI_MODE_ABM, /* Normal Asynchronous Balanced Mode */
DLCI_MODE_ADM, /* Asynchronous Disconnected Mode */
};

/*
* Each active data link has a gsm_dlci structure associated which ties
* the link layer to an optional tty (if the tty side is open). To avoid
Expand All @@ -124,9 +129,7 @@ struct gsm_dlci {
struct mutex mutex;

/* Link layer */
int mode;
#define DLCI_MODE_ABM 0 /* Normal Asynchronous Balanced Mode */
#define DLCI_MODE_ADM 1 /* Asynchronous Disconnected Mode */
enum gsm_dlci_mode mode;
spinlock_t lock; /* Protects the internal state */
struct timer_list t1; /* Retransmit timer for SABM and UA */
int retries;
Expand Down

0 comments on commit e178599

Please sign in to comment.