Skip to content

Commit

Permalink
drm/i915: Nuke pointless variable
Browse files Browse the repository at this point in the history
No point in assigning the function return value to a local
variable if we're just going to use it the one time.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200630215601.28557-13-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
  • Loading branch information
Ville Syrjälä committed Sep 15, 2020
1 parent 6d3144e commit e198eea
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpu/drm/i915/display/intel_hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -482,15 +482,14 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
* only the one of them (DP) will have ->hpd_pulse().
*/
for_each_intel_encoder(&dev_priv->drm, encoder) {
bool has_hpd_pulse = intel_encoder_has_hpd_pulse(encoder);
enum port port = encoder->port;
bool long_hpd;

pin = encoder->hpd_pin;
if (!(BIT(pin) & pin_mask))
continue;

if (!has_hpd_pulse)
if (!intel_encoder_has_hpd_pulse(encoder))
continue;

long_hpd = long_mask & BIT(pin);
Expand Down

0 comments on commit e198eea

Please sign in to comment.