Skip to content

Commit

Permalink
xfrm: use "unsigned int" in addr_match()
Browse files Browse the repository at this point in the history
x86_64 is zero-extending arch so "unsigned int" is preferred over "int"
for address calculations and extending to size_t.

Space savings:

	add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-24 (-24)
	function                                     old     new   delta
	xfrm_state_walk                              708     696     -12
	xfrm_selector_match                          918     906     -12

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
  • Loading branch information
Alexey Dobriyan authored and Steffen Klassert committed Mar 24, 2017
1 parent d7f6946 commit e1b0048
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions include/net/xfrm.h
Original file line number Diff line number Diff line change
Expand Up @@ -816,12 +816,12 @@ static inline void xfrm_state_hold(struct xfrm_state *x)
}

static inline bool addr_match(const void *token1, const void *token2,
int prefixlen)
unsigned int prefixlen)
{
const __be32 *a1 = token1;
const __be32 *a2 = token2;
int pdw;
int pbi;
unsigned int pdw;
unsigned int pbi;

pdw = prefixlen >> 5; /* num of whole u32 in prefix */
pbi = prefixlen & 0x1f; /* num of bits in incomplete u32 in prefix */
Expand Down

0 comments on commit e1b0048

Please sign in to comment.