Skip to content

Commit

Permalink
IB/mthca: Fix section mismatch problems
Browse files Browse the repository at this point in the history
Quite a few cleanup functions in mthca were marked as __devexit.
However, they could also be called from error paths during
initialization, so they cannot be marked that way.  Just delete all of
the incorrect annotations.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Roland Dreier committed Mar 29, 2006
1 parent ef12d45 commit e1f7868
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_av.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ int __devinit mthca_init_av_table(struct mthca_dev *dev)
return -ENOMEM;
}

void __devexit mthca_cleanup_av_table(struct mthca_dev *dev)
void mthca_cleanup_av_table(struct mthca_dev *dev)
{
if (mthca_is_memfree(dev))
return;
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_cq.c
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ int __devinit mthca_init_cq_table(struct mthca_dev *dev)
return err;
}

void __devexit mthca_cleanup_cq_table(struct mthca_dev *dev)
void mthca_cleanup_cq_table(struct mthca_dev *dev)
{
mthca_array_cleanup(&dev->cq_table.cq, dev->limits.num_cqs);
mthca_alloc_cleanup(&dev->cq_table.alloc);
Expand Down
6 changes: 3 additions & 3 deletions drivers/infiniband/hw/mthca/mthca_eq.c
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ static int __devinit mthca_map_eq_regs(struct mthca_dev *dev)

}

static void __devexit mthca_unmap_eq_regs(struct mthca_dev *dev)
static void mthca_unmap_eq_regs(struct mthca_dev *dev)
{
if (mthca_is_memfree(dev)) {
mthca_unmap_reg(dev, (pci_resource_len(dev->pdev, 0) - 1) &
Expand Down Expand Up @@ -821,7 +821,7 @@ int __devinit mthca_map_eq_icm(struct mthca_dev *dev, u64 icm_virt)
return ret;
}

void __devexit mthca_unmap_eq_icm(struct mthca_dev *dev)
void mthca_unmap_eq_icm(struct mthca_dev *dev)
{
u8 status;

Expand Down Expand Up @@ -954,7 +954,7 @@ int __devinit mthca_init_eq_table(struct mthca_dev *dev)
return err;
}

void __devexit mthca_cleanup_eq_table(struct mthca_dev *dev)
void mthca_cleanup_eq_table(struct mthca_dev *dev)
{
u8 status;
int i;
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_mad.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ int mthca_create_agents(struct mthca_dev *dev)
return PTR_ERR(agent);
}

void mthca_free_agents(struct mthca_dev *dev)
void __devexit mthca_free_agents(struct mthca_dev *dev)
{
struct ib_mad_agent *agent;
int p, q;
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_mcg.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ int __devinit mthca_init_mcg_table(struct mthca_dev *dev)
return 0;
}

void __devexit mthca_cleanup_mcg_table(struct mthca_dev *dev)
void mthca_cleanup_mcg_table(struct mthca_dev *dev)
{
mthca_alloc_cleanup(&dev->mcg_table.alloc);
}
4 changes: 2 additions & 2 deletions drivers/infiniband/hw/mthca/mthca_mr.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ static int __devinit mthca_buddy_init(struct mthca_buddy *buddy, int max_order)
return -ENOMEM;
}

static void __devexit mthca_buddy_cleanup(struct mthca_buddy *buddy)
static void mthca_buddy_cleanup(struct mthca_buddy *buddy)
{
int i;

Expand Down Expand Up @@ -866,7 +866,7 @@ int __devinit mthca_init_mr_table(struct mthca_dev *dev)
return err;
}

void __devexit mthca_cleanup_mr_table(struct mthca_dev *dev)
void mthca_cleanup_mr_table(struct mthca_dev *dev)
{
/* XXX check if any MRs are still allocated? */
if (dev->limits.fmr_reserved_mtts)
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_pd.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ int __devinit mthca_init_pd_table(struct mthca_dev *dev)
dev->limits.reserved_pds);
}

void __devexit mthca_cleanup_pd_table(struct mthca_dev *dev)
void mthca_cleanup_pd_table(struct mthca_dev *dev)
{
/* XXX check if any PDs are still allocated? */
mthca_alloc_cleanup(&dev->pd_table.alloc);
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_qp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2204,7 +2204,7 @@ int __devinit mthca_init_qp_table(struct mthca_dev *dev)
return err;
}

void __devexit mthca_cleanup_qp_table(struct mthca_dev *dev)
void mthca_cleanup_qp_table(struct mthca_dev *dev)
{
int i;
u8 status;
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_srq.c
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ int __devinit mthca_init_srq_table(struct mthca_dev *dev)
return err;
}

void __devexit mthca_cleanup_srq_table(struct mthca_dev *dev)
void mthca_cleanup_srq_table(struct mthca_dev *dev)
{
if (!(dev->mthca_flags & MTHCA_FLAG_SRQ))
return;
Expand Down

0 comments on commit e1f7868

Please sign in to comment.