Skip to content

Commit

Permalink
ipc/sem: drop __sem_free()
Browse files Browse the repository at this point in the history
The remaining users of __sem_free() can simply call kvfree() instead for
better readability.

[manfred@colorfullife.com: Rediff to keep rcu protection for security_sem_alloc()]
Link: http://lkml.kernel.org/r/20170525185107.12869-20-manfred@colorfullife.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Kees Cook authored and Linus Torvalds committed Jul 12, 2017
1 parent fb259c3 commit e2029df
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions ipc/sem.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,18 +258,13 @@ static void merge_queues(struct sem_array *sma)
}
}

static void __sem_free(struct sem_array *sma)
{
kvfree(sma);
}

static void sem_rcu_free(struct rcu_head *head)
{
struct kern_ipc_perm *p = container_of(head, struct kern_ipc_perm, rcu);
struct sem_array *sma = container_of(p, struct sem_array, sem_perm);

security_sem_free(sma);
__sem_free(sma);
kvfree(sma);
}

/*
Expand Down Expand Up @@ -500,7 +495,7 @@ static int newary(struct ipc_namespace *ns, struct ipc_params *params)
sma->sem_perm.security = NULL;
retval = security_sem_alloc(sma);
if (retval) {
__sem_free(sma);
kvfree(sma);
return retval;
}

Expand Down

0 comments on commit e2029df

Please sign in to comment.