Skip to content

Commit

Permalink
net: ethernet: mtk_wed: Fix missing of_node_put() in mtk_wed_wo_hardw…
Browse files Browse the repository at this point in the history
…are_init()

The np needs to be released through of_node_put() in the error handling
path of mtk_wed_wo_hardware_init().

Fixes: 7996844 ("net: ethernet: mtk_wed: introduce wed wo support")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221205034339.112163-1-yuancan@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Yuan Can authored and Paolo Abeni committed Dec 7, 2022
1 parent ed883be commit e22dcbc
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/net/ethernet/mediatek/mtk_wed_wo.c
Original file line number Diff line number Diff line change
@@ -408,8 +408,10 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo)
return -ENODEV;

wo->mmio.regs = syscon_regmap_lookup_by_phandle(np, NULL);
if (IS_ERR_OR_NULL(wo->mmio.regs))
return PTR_ERR(wo->mmio.regs);
if (IS_ERR(wo->mmio.regs)) {
ret = PTR_ERR(wo->mmio.regs);
goto error_put;
}

wo->mmio.irq = irq_of_parse_and_map(np, 0);
wo->mmio.irq_mask = MTK_WED_WO_ALL_INT_MASK;
@@ -457,7 +459,8 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo)

error:
devm_free_irq(wo->hw->dev, wo->mmio.irq, wo);

error_put:
of_node_put(np);
return ret;
}

0 comments on commit e22dcbc

Please sign in to comment.