Skip to content

Commit

Permalink
fs: push the getname from do_rmdir into the callers
Browse files Browse the repository at this point in the history
This mirrors do_unlinkat and will make life a little easier for
the init code to reuse the whole function with a kernel filename.

Signed-off-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
Christoph Hellwig committed Jul 31, 2020
1 parent 41525f5 commit e24ab0e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion fs/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ extern int vfs_path_lookup(struct dentry *, struct vfsmount *,
long do_mknodat(int dfd, const char __user *filename, umode_t mode,
unsigned int dev);
long do_mkdirat(int dfd, const char __user *pathname, umode_t mode);
long do_rmdir(int dfd, const char __user *pathname);
long do_rmdir(int dfd, struct filename *name);
long do_unlinkat(int dfd, struct filename *name);
long do_symlinkat(const char __user *oldname, int newdfd,
const char __user *newname);
Expand Down
10 changes: 4 additions & 6 deletions fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -3720,17 +3720,16 @@ int vfs_rmdir(struct inode *dir, struct dentry *dentry)
}
EXPORT_SYMBOL(vfs_rmdir);

long do_rmdir(int dfd, const char __user *pathname)
long do_rmdir(int dfd, struct filename *name)
{
int error = 0;
struct filename *name;
struct dentry *dentry;
struct path path;
struct qstr last;
int type;
unsigned int lookup_flags = 0;
retry:
name = filename_parentat(dfd, getname(pathname), lookup_flags,
name = filename_parentat(dfd, name, lookup_flags,
&path, &last, &type);
if (IS_ERR(name))
return PTR_ERR(name);
Expand Down Expand Up @@ -3781,7 +3780,7 @@ long do_rmdir(int dfd, const char __user *pathname)

SYSCALL_DEFINE1(rmdir, const char __user *, pathname)
{
return do_rmdir(AT_FDCWD, pathname);
return do_rmdir(AT_FDCWD, getname(pathname));
}

/**
Expand Down Expand Up @@ -3926,8 +3925,7 @@ SYSCALL_DEFINE3(unlinkat, int, dfd, const char __user *, pathname, int, flag)
return -EINVAL;

if (flag & AT_REMOVEDIR)
return do_rmdir(dfd, pathname);

return do_rmdir(dfd, getname(pathname));
return do_unlinkat(dfd, getname(pathname));
}

Expand Down
4 changes: 2 additions & 2 deletions include/linux/syscalls.h
Original file line number Diff line number Diff line change
Expand Up @@ -1281,11 +1281,11 @@ static inline long ksys_unlink(const char __user *pathname)
return do_unlinkat(AT_FDCWD, getname(pathname));
}

extern long do_rmdir(int dfd, const char __user *pathname);
long do_rmdir(int dfd, struct filename *name);

static inline long ksys_rmdir(const char __user *pathname)
{
return do_rmdir(AT_FDCWD, pathname);
return do_rmdir(AT_FDCWD, getname(pathname));
}

extern long do_mkdirat(int dfd, const char __user *pathname, umode_t mode);
Expand Down

0 comments on commit e24ab0e

Please sign in to comment.