Skip to content

Commit

Permalink
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
Browse files Browse the repository at this point in the history
Add error pointer check after calling otx2_mbox_get_rsp().

Fixes: 75f3627 ("octeontx2-pf: Support to enable/disable pause frames via ethtool")
Fixes: d0cf950 ("octeontx2-pf: ethtool fec mode support")
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
  • Loading branch information
Dipendra Khadka authored and Andrew Lunn committed Oct 22, 2024
1 parent 0fbc7a5 commit e26f8ea
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ static void otx2_get_pauseparam(struct net_device *netdev,
if (!otx2_sync_mbox_msg(&pfvf->mbox)) {
rsp = (struct cgx_pause_frm_cfg *)
otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
if (IS_ERR(rsp)) {
mutex_unlock(&pfvf->mbox.lock);
return;
}

pause->rx_pause = rsp->rx_pause;
pause->tx_pause = rsp->tx_pause;
}
Expand Down Expand Up @@ -1072,6 +1077,11 @@ static int otx2_set_fecparam(struct net_device *netdev,

rsp = (struct fec_mode *)otx2_mbox_get_rsp(&pfvf->mbox.mbox,
0, &req->hdr);
if (IS_ERR(rsp)) {
err = PTR_ERR(rsp);
goto end;
}

if (rsp->fec >= 0)
pfvf->linfo.fec = rsp->fec;
else
Expand Down

0 comments on commit e26f8ea

Please sign in to comment.