Skip to content

Commit

Permalink
Merge branch 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/g…
Browse files Browse the repository at this point in the history
…it/tiwai/sound-2.6

* 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
  ALSA: hda - Add a PC-beep workaround for ASUS P5-V
  ALSA: hda - Assume PC-beep as default for Realtek
  ALSA: hda - Don't register beep input device when no beep is available
  ALSA: hda - Fix pin-detection of Nvidia HDMI
  • Loading branch information
Linus Torvalds committed Jul 29, 2010
2 parents 8f92054 + dc1eae2 commit e271e87
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 20 deletions.
13 changes: 13 additions & 0 deletions sound/pci/hda/patch_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ struct hdmi_spec {
*/
struct hda_multi_out multiout;
unsigned int codec_type;

/* misc flags */
/* PD bit indicates only the update, not the current state */
unsigned int old_pin_detect:1;
};


Expand Down Expand Up @@ -616,6 +620,9 @@ static void hdmi_setup_audio_infoframe(struct hda_codec *codec, hda_nid_t nid,
* Unsolicited events
*/

static void hdmi_present_sense(struct hda_codec *codec, hda_nid_t pin_nid,
struct hdmi_eld *eld);

static void hdmi_intrinsic_event(struct hda_codec *codec, unsigned int res)
{
struct hdmi_spec *spec = codec->spec;
Expand All @@ -632,6 +639,12 @@ static void hdmi_intrinsic_event(struct hda_codec *codec, unsigned int res)
if (index < 0)
return;

if (spec->old_pin_detect) {
if (pind)
hdmi_present_sense(codec, tag, &spec->sink_eld[index]);
pind = spec->sink_eld[index].monitor_present;
}

spec->sink_eld[index].monitor_present = pind;
spec->sink_eld[index].eld_valid = eldv;

Expand Down
3 changes: 3 additions & 0 deletions sound/pci/hda/patch_nvhdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ static int patch_nvhdmi_8ch_89(struct hda_codec *codec)

codec->spec = spec;
spec->codec_type = HDA_CODEC_NVIDIA_MCP89;
spec->old_pin_detect = 1;

if (hdmi_parse_codec(codec) < 0) {
codec->spec = NULL;
Expand Down Expand Up @@ -508,6 +509,7 @@ static int patch_nvhdmi_8ch_7x(struct hda_codec *codec)
spec->multiout.max_channels = 8;
spec->multiout.dig_out_nid = nvhdmi_master_con_nid_7x;
spec->codec_type = HDA_CODEC_NVIDIA_MCP7X;
spec->old_pin_detect = 1;

codec->patch_ops = nvhdmi_patch_ops_8ch_7x;

Expand All @@ -528,6 +530,7 @@ static int patch_nvhdmi_2ch(struct hda_codec *codec)
spec->multiout.max_channels = 2;
spec->multiout.dig_out_nid = nvhdmi_master_con_nid_7x;
spec->codec_type = HDA_CODEC_NVIDIA_MCP7X;
spec->old_pin_detect = 1;

codec->patch_ops = nvhdmi_patch_ops_2ch;

Expand Down
62 changes: 42 additions & 20 deletions sound/pci/hda/patch_realtek.c
Original file line number Diff line number Diff line change
Expand Up @@ -1267,11 +1267,11 @@ static int alc_auto_parse_customize_define(struct hda_codec *codec)
unsigned nid = 0;
struct alc_spec *spec = codec->spec;

spec->cdefine.enable_pcbeep = 1; /* assume always enabled */

ass = codec->subsystem_id & 0xffff;
if (ass != codec->bus->pci->subsystem_device && (ass & 1)) {
spec->cdefine.enable_pcbeep = 1; /* assume always enabled */
if (ass != codec->bus->pci->subsystem_device && (ass & 1))
goto do_sku;
}

nid = 0x1d;
if (codec->vendor_id == 0x10ec0260)
Expand Down Expand Up @@ -5180,8 +5180,24 @@ static void fillup_priv_adc_nids(struct hda_codec *codec, hda_nid_t *nids,
#ifdef CONFIG_SND_HDA_INPUT_BEEP
#define set_beep_amp(spec, nid, idx, dir) \
((spec)->beep_amp = HDA_COMPOSE_AMP_VAL(nid, 3, idx, dir))

static struct snd_pci_quirk beep_white_list[] = {
SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
{}
};

static inline int has_cdefine_beep(struct hda_codec *codec)
{
struct alc_spec *spec = codec->spec;
const struct snd_pci_quirk *q;
q = snd_pci_quirk_lookup(codec->bus->pci, beep_white_list);
if (q)
return q->value;
return spec->cdefine.enable_pcbeep;
}
#else
#define set_beep_amp(spec, nid, idx, dir) /* NOP */
#define has_cdefine_beep(codec) 0
#endif

/*
Expand Down Expand Up @@ -10566,10 +10582,12 @@ static int patch_alc882(struct hda_codec *codec)
}
}

err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
if (has_cdefine_beep(codec)) {
err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
}
}

if (board_config != ALC882_AUTO)
Expand Down Expand Up @@ -10619,7 +10637,7 @@ static int patch_alc882(struct hda_codec *codec)

set_capture_mixer(codec);

if (spec->cdefine.enable_pcbeep)
if (has_cdefine_beep(codec))
set_beep_amp(spec, 0x0b, 0x05, HDA_INPUT);

if (board_config == ALC882_AUTO)
Expand Down Expand Up @@ -12435,7 +12453,7 @@ static int patch_alc262(struct hda_codec *codec)
}
}

if (!spec->no_analog) {
if (!spec->no_analog && has_cdefine_beep(codec)) {
err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
Expand Down Expand Up @@ -12486,7 +12504,7 @@ static int patch_alc262(struct hda_codec *codec)
}
if (!spec->cap_mixer && !spec->no_analog)
set_capture_mixer(codec);
if (!spec->no_analog && spec->cdefine.enable_pcbeep)
if (!spec->no_analog && has_cdefine_beep(codec))
set_beep_amp(spec, 0x0b, 0x05, HDA_INPUT);

spec->vmaster_nid = 0x0c;
Expand Down Expand Up @@ -14458,10 +14476,12 @@ static int patch_alc269(struct hda_codec *codec)
}
}

err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
if (has_cdefine_beep(codec)) {
err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
}
}

if (board_config != ALC269_AUTO)
Expand Down Expand Up @@ -14494,7 +14514,7 @@ static int patch_alc269(struct hda_codec *codec)

if (!spec->cap_mixer)
set_capture_mixer(codec);
if (spec->cdefine.enable_pcbeep)
if (has_cdefine_beep(codec))
set_beep_amp(spec, 0x0b, 0x04, HDA_INPUT);

if (board_config == ALC269_AUTO)
Expand Down Expand Up @@ -18691,10 +18711,12 @@ static int patch_alc662(struct hda_codec *codec)
}
}

err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
if (has_cdefine_beep(codec)) {
err = snd_hda_attach_beep_device(codec, 0x1);
if (err < 0) {
alc_free(codec);
return err;
}
}

if (board_config != ALC662_AUTO)
Expand All @@ -18716,7 +18738,7 @@ static int patch_alc662(struct hda_codec *codec)
if (!spec->cap_mixer)
set_capture_mixer(codec);

if (spec->cdefine.enable_pcbeep) {
if (has_cdefine_beep(codec)) {
switch (codec->vendor_id) {
case 0x10ec0662:
set_beep_amp(spec, 0x0b, 0x05, HDA_INPUT);
Expand Down

0 comments on commit e271e87

Please sign in to comment.