Skip to content

Commit

Permalink
thermal/drivers/hisi: Remove pointless lock
Browse files Browse the repository at this point in the history
commit 2d4fa7b upstream.

The threaded interrupt inspect the sensors structure to look in the temp
threshold field, but this field is read-only in all the code, except in the
probe function before the threaded interrupt is set. In other words there
is not race window in the threaded interrupt when reading the field value.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Daniel Lezcano authored and Greg Kroah-Hartman committed Dec 8, 2018
1 parent 4025194 commit e29649e
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/thermal/hisi_thermal.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev)
static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)
{
struct hisi_thermal_data *data = dev;
struct hisi_thermal_sensor *sensor;

mutex_lock(&data->thermal_lock);
sensor = &data->sensors;
struct hisi_thermal_sensor *sensor = &data->sensors;

dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",
sensor->thres_temp);
mutex_unlock(&data->thermal_lock);

thermal_zone_device_update(data->sensors.tzd,
THERMAL_EVENT_UNSPECIFIED);
Expand Down

0 comments on commit e29649e

Please sign in to comment.