Skip to content

Commit

Permalink
can: usb_8dev: add LED trigger support
Browse files Browse the repository at this point in the history
Add support for canbus activity led indicators on usb_8dev devices by
calling appropriate can_led functions.

These are only enabled when CONFIG_CAN_LEDS is Y, becomes no-op
otherwise.

Signed-off-by: Bernd Krumboeck <krumboeck@universalnet.at>
Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Bernd Krumboeck authored and Marc Kleine-Budde committed Jan 26, 2013
1 parent a04282f commit e2d5f2c
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions drivers/net/can/usb/usb_8dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <linux/can.h>
#include <linux/can/dev.h>
#include <linux/can/error.h>
#include <linux/can/led.h>

/* driver constants */
#define MAX_RX_URBS 20
Expand Down Expand Up @@ -497,6 +498,8 @@ static void usb_8dev_rx_can_msg(struct usb_8dev_priv *priv,

stats->rx_packets++;
stats->rx_bytes += cf->can_dlc;

can_led_event(priv->netdev, CAN_LED_EVENT_RX);
} else {
netdev_warn(priv->netdev, "frame type %d unknown",
msg->type);
Expand Down Expand Up @@ -597,6 +600,8 @@ static void usb_8dev_write_bulk_callback(struct urb *urb)

can_get_echo_skb(netdev, context->echo_index);

can_led_event(netdev, CAN_LED_EVENT_TX);

/* Release context */
context->echo_index = MAX_TX_URBS;

Expand Down Expand Up @@ -819,6 +824,8 @@ static int usb_8dev_open(struct net_device *netdev)
if (err)
return err;

can_led_event(netdev, CAN_LED_EVENT_OPEN);

/* finally start device */
err = usb_8dev_start(priv);
if (err) {
Expand Down Expand Up @@ -871,6 +878,8 @@ static int usb_8dev_close(struct net_device *netdev)

close_candev(netdev);

can_led_event(netdev, CAN_LED_EVENT_STOP);

return err;
}

Expand Down Expand Up @@ -978,6 +987,8 @@ static int usb_8dev_probe(struct usb_interface *intf,
(version>>8) & 0xff, version & 0xff);
}

devm_can_led_init(netdev);

return 0;

cleanup_cmd_msg_buffer:
Expand Down

0 comments on commit e2d5f2c

Please sign in to comment.