Skip to content

Commit

Permalink
powerpc/pseries: Add and use LPPACA_SIZE constant
Browse files Browse the repository at this point in the history
Helps document what the hard-coded number means.

Also take the opportunity to fix an #endif comment.

Suggested-by: Alexey Kardashevskiy <aik@linux.ibm.com>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190820021326.6884-8-bauerman@linux.ibm.com
  • Loading branch information
Thiago Jung Bauermann authored and Michael Ellerman committed Aug 29, 2019
1 parent 7f70c38 commit e311a92
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions arch/powerpc/kernel/paca.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ static void *__init alloc_paca_data(unsigned long size, unsigned long align,

#ifdef CONFIG_PPC_PSERIES

#define LPPACA_SIZE 0x400

/*
* See asm/lppaca.h for more detail.
*
Expand All @@ -65,7 +67,7 @@ static inline void init_lppaca(struct lppaca *lppaca)

*lppaca = (struct lppaca) {
.desc = cpu_to_be32(0xd397d781), /* "LpPa" */
.size = cpu_to_be16(0x400),
.size = cpu_to_be16(LPPACA_SIZE),
.fpregs_in_use = 1,
.slb_count = cpu_to_be16(64),
.vmxregs_in_use = 0,
Expand All @@ -75,19 +77,18 @@ static inline void init_lppaca(struct lppaca *lppaca)
static struct lppaca * __init new_lppaca(int cpu, unsigned long limit)
{
struct lppaca *lp;
size_t size = 0x400;

BUILD_BUG_ON(size < sizeof(struct lppaca));
BUILD_BUG_ON(sizeof(struct lppaca) > LPPACA_SIZE);

if (early_cpu_has_feature(CPU_FTR_HVMODE))
return NULL;

lp = alloc_paca_data(size, 0x400, limit, cpu);
lp = alloc_paca_data(LPPACA_SIZE, 0x400, limit, cpu);
init_lppaca(lp);

return lp;
}
#endif /* CONFIG_PPC_BOOK3S */
#endif /* CONFIG_PPC_PSERIES */

#ifdef CONFIG_PPC_BOOK3S_64

Expand Down

0 comments on commit e311a92

Please sign in to comment.