Skip to content

Commit

Permalink
drm/i915/ringbuffer: Remove broken intel_fill_struct()
Browse files Browse the repository at this point in the history
... before someone tries to use it. The code both calls
intel_ring_begin/advance() and open-codes the bookkeeping performed by
those two functions.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Oct 21, 2010
1 parent c717966 commit e36c1cd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
15 changes: 0 additions & 15 deletions drivers/gpu/drm/i915/intel_ringbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -733,21 +733,6 @@ void intel_ring_advance(struct drm_device *dev,
ring->set_tail(dev, ring, ring->tail);
}

void intel_fill_struct(struct drm_device *dev,
struct intel_ring_buffer *ring,
void *data,
unsigned int len)
{
unsigned int *virt = ring->virtual_start + ring->tail;
BUG_ON((len&~(4-1)) != 0);
intel_ring_begin(dev, ring, len/4);
memcpy(virt, data, len);
ring->tail += len;
ring->tail &= ring->size - 1;
ring->space -= len;
intel_ring_advance(dev, ring);
}

static const struct intel_ring_buffer render_ring = {
.name = "render ring",
.id = RING_RENDER,
Expand Down
4 changes: 0 additions & 4 deletions drivers/gpu/drm/i915/intel_ringbuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ static inline void intel_ring_emit(struct drm_device *dev,
ring->tail += 4;
}

void intel_fill_struct(struct drm_device *dev,
struct intel_ring_buffer *ring,
void *data,
unsigned int len);
void intel_ring_advance(struct drm_device *dev,
struct intel_ring_buffer *ring);

Expand Down

0 comments on commit e36c1cd

Please sign in to comment.