Skip to content

Commit

Permalink
btrfs: convert btrfs_dio_private->pending_bios to refcount_t
Browse files Browse the repository at this point in the history
This is really a reference count now, so convert it to refcount_t and
rename it to refs.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
  • Loading branch information
Omar Sandoval authored and David Sterba committed May 25, 2020
1 parent 2390a6d commit e3b318d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
8 changes: 6 additions & 2 deletions fs/btrfs/btrfs_inode.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#define BTRFS_INODE_H

#include <linux/hash.h>
#include <linux/refcount.h>
#include "extent_map.h"
#include "extent_io.h"
#include "ordered-data.h"
Expand Down Expand Up @@ -302,8 +303,11 @@ struct btrfs_dio_private {
u64 disk_bytenr;
u64 bytes;

/* number of bios pending for this dio */
atomic_t pending_bios;
/*
* References to this structure. There is one reference per in-flight
* bio plus one while we're still setting up.
*/
refcount_t refs;

/* IO errors */
int errors;
Expand Down
10 changes: 5 additions & 5 deletions fs/btrfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -7811,7 +7811,7 @@ static void btrfs_end_dio_bio(struct bio *bio)
}

/* if there are more bios still pending for this dio, just exit */
if (!atomic_dec_and_test(&dip->pending_bios))
if (!refcount_dec_and_test(&dip->refs))
goto out;

if (dip->errors) {
Expand Down Expand Up @@ -7929,7 +7929,7 @@ static struct btrfs_dio_private *btrfs_create_dio_private(struct bio *dio_bio,
dip->disk_bytenr = (u64)dio_bio->bi_iter.bi_sector << 9;
dip->orig_bio = bio;
dip->dio_bio = dio_bio;
atomic_set(&dip->pending_bios, 1);
refcount_set(&dip->refs, 1);

if (write) {
struct btrfs_dio_data *dio_data = current->journal_info;
Expand Down Expand Up @@ -8025,13 +8025,13 @@ static void btrfs_submit_direct(struct bio *dio_bio, struct inode *inode,
* count. Otherwise, the dip might get freed before we're
* done setting it up.
*/
atomic_inc(&dip->pending_bios);
refcount_inc(&dip->refs);

status = btrfs_submit_dio_bio(bio, inode, file_offset,
async_submit);
if (status) {
bio_put(bio);
atomic_dec(&dip->pending_bios);
refcount_dec(&dip->refs);
goto out_err;
}

Expand Down Expand Up @@ -8060,7 +8060,7 @@ static void btrfs_submit_direct(struct bio *dio_bio, struct inode *inode,
* atomic operations with a return value are fully ordered as per
* atomic_t.txt
*/
if (atomic_dec_and_test(&dip->pending_bios))
if (refcount_dec_and_test(&dip->refs))
bio_io_error(dip->orig_bio);
}

Expand Down

0 comments on commit e3b318d

Please sign in to comment.