Skip to content

Commit

Permalink
drm/msm: Set the global virtual address range from the IOMMU domain
Browse files Browse the repository at this point in the history
Use the aperture settings from the IOMMU domain to set up the virtual
address range for the GPU. This allows us to transparently deal with
IOMMU side features (like split pagetables).

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Jordan Crouse authored and Rob Clark committed Sep 12, 2020
1 parent 15eb9ad commit e3c64c7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
13 changes: 11 additions & 2 deletions drivers/gpu/drm/msm/adreno/adreno_gpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,24 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,
struct iommu_domain *iommu;
struct msm_mmu *mmu;
struct msm_gem_address_space *aspace;
u64 start, size;

iommu = iommu_domain_alloc(&platform_bus_type);
if (!iommu)
return NULL;

mmu = msm_iommu_new(&pdev->dev, iommu);

aspace = msm_gem_address_space_create(mmu, "gpu", SZ_16M,
0xffffffff - SZ_16M);
/*
* Use the aperture start or SZ_16M, whichever is greater. This will
* ensure that we align with the allocated pagetable range while still
* allowing room in the lower 32 bits for GMEM and whatnot
*/
start = max_t(u64, SZ_16M, iommu->geometry.aperture_start);
size = iommu->geometry.aperture_end - start + 1;

aspace = msm_gem_address_space_create(mmu, "gpu",
start & GENMASK(48, 0), size);

if (IS_ERR(aspace) && !IS_ERR(mmu))
mmu->funcs->destroy(mmu);
Expand Down
7 changes: 7 additions & 0 deletions drivers/gpu/drm/msm/msm_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova,
struct msm_iommu *iommu = to_msm_iommu(mmu);
size_t ret;

/* The arm-smmu driver expects the addresses to be sign extended */
if (iova & BIT_ULL(48))
iova |= GENMASK_ULL(63, 49);

ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot);
WARN_ON(!ret);

Expand All @@ -46,6 +50,9 @@ static int msm_iommu_unmap(struct msm_mmu *mmu, uint64_t iova, size_t len)
{
struct msm_iommu *iommu = to_msm_iommu(mmu);

if (iova & BIT_ULL(48))
iova |= GENMASK_ULL(63, 49);

iommu_unmap(iommu->domain, iova, len);

return 0;
Expand Down

0 comments on commit e3c64c7

Please sign in to comment.