Skip to content

Commit

Permalink
scripts: override locale from environment when running recordmcount.pl
Browse files Browse the repository at this point in the history
recordmcount.pl uses a set of regular expressions to parse the output of
objdump(1). However, if objdump(1) output is localized, it may not match
the regular expressions, thereby preventing recordmcount.pl from parsing
object files correctly.

In order to allow recordmcount.pl to function correctly regardless of the
current locale settings, set LANG=C when running objdump(1). LC_ALL is
already unset in the top-level Makefile, so it is not necessary to also
override that environment variable.

Signed-off-by: Daniel Dadap <ddadap@nvidia.com>
Reviewed-by: Robert Morell <rmorell@nvidia.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
  • Loading branch information
Daniel Dadap authored and Masahiro Yamada committed May 3, 2019
1 parent e7e3491 commit e46b94d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/recordmcount.pl
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ sub update_funcs
#
# Step 2: find the sections and mcount call sites
#
open(IN, "$objdump -hdr $inputfile|") || die "error running $objdump";
open(IN, "LANG=C $objdump -hdr $inputfile|") || die "error running $objdump";

my $text;

Expand Down

0 comments on commit e46b94d

Please sign in to comment.