Skip to content

Commit

Permalink
net/ipv4: Bail early if user only wants prefix entries
Browse files Browse the repository at this point in the history
Unlike IPv6, IPv4 does not have routes marked with RTF_PREFIX_RT. If the
flag is set in the dump request, just return.

In the process of this change, move the CLONE check to use the new
filter flags.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Ahern authored and David S. Miller committed Oct 16, 2018
1 parent 08e814c commit e4e92fb
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions net/ipv4/fib_frontend.c
Original file line number Diff line number Diff line change
Expand Up @@ -886,10 +886,14 @@ static int inet_dump_fib(struct sk_buff *skb, struct netlink_callback *cb)
err = ip_valid_fib_dump_req(net, nlh, &filter, cb);
if (err < 0)
return err;
} else if (nlmsg_len(nlh) >= sizeof(struct rtmsg)) {
struct rtmsg *rtm = nlmsg_data(nlh);

filter.flags = rtm->rtm_flags & (RTM_F_PREFIX | RTM_F_CLONED);
}

if (nlmsg_len(nlh) >= sizeof(struct rtmsg) &&
((struct rtmsg *)nlmsg_data(nlh))->rtm_flags & RTM_F_CLONED)
/* fib entries are never clones and ipv4 does not use prefix flag */
if (filter.flags & (RTM_F_PREFIX | RTM_F_CLONED))
return skb->len;

if (filter.table_id) {
Expand Down

0 comments on commit e4e92fb

Please sign in to comment.