-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Coccinelle: Script to detect incorrect argument to sizeof
This makes an effort to find cases where the argument to sizeof is wrong in memory allocation functions by checking the type of the allocated memory when it is a double pointer and ensuring the sizeof argument takes a pointer to the the memory being allocated. There are false positives in cases the sizeof argument is not used in constructing the return value. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Michal Marek <mmarek@suse.cz>
- Loading branch information
Himangi Saraogi
authored and
Michal Marek
committed
Aug 6, 2014
1 parent
7ab04ea
commit e52320c
Showing
1 changed file
with
76 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/// Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element | ||
/// | ||
//# This makes an effort to find cases where the argument to sizeof is wrong | ||
//# in memory allocation functions by checking the type of the allocated memory | ||
//# when it is a double pointer and ensuring the sizeof argument takes a pointer | ||
//# to the the memory being allocated. There are false positives in cases the | ||
//# sizeof argument is not used in constructing the return value. The result | ||
//# may need some reformatting. | ||
// | ||
// Confidence: Moderate | ||
// Copyright: (C) 2014 Himangi Saraogi. GPLv2. | ||
// Comments: | ||
// Options: | ||
|
||
virtual patch | ||
virtual context | ||
virtual org | ||
virtual report | ||
|
||
//---------------------------------------------------------- | ||
// For context mode | ||
//---------------------------------------------------------- | ||
|
||
@depends on context disable sizeof_type_expr@ | ||
type T; | ||
T **x; | ||
@@ | ||
|
||
x = | ||
<+...sizeof( | ||
* T | ||
)...+> | ||
|
||
//---------------------------------------------------------- | ||
// For patch mode | ||
//---------------------------------------------------------- | ||
|
||
@depends on patch disable sizeof_type_expr@ | ||
type T; | ||
T **x; | ||
@@ | ||
|
||
x = | ||
<+...sizeof( | ||
- T | ||
+ *x | ||
)...+> | ||
|
||
//---------------------------------------------------------- | ||
// For org and report mode | ||
//---------------------------------------------------------- | ||
|
||
@r disable sizeof_type_expr@ | ||
type T; | ||
T **x; | ||
position p; | ||
@@ | ||
|
||
x = | ||
<+...sizeof( | ||
T@p | ||
)...+> | ||
|
||
@script:python depends on org@ | ||
p << r.p; | ||
@@ | ||
coccilib.org.print_todo(p[0], "WARNING sizeof argument should be pointer type, not structure type") | ||
@script:python depends on report@ | ||
p << r.p; | ||
@@ | ||
msg="WARNING: Use correct pointer type argument for sizeof" | ||
coccilib.report.print_report(p[0], msg) | ||