Skip to content

Commit

Permalink
drm/ast: Fix connector leak during driver unload
Browse files Browse the repository at this point in the history
When unloading the ast driver, a warning message is printed by
drm_mode_config_cleanup() because a reference is still held to one of
the drm_connector structs.

Correct this by calling drm_crtc_force_disable_all() in
ast_fbdev_destroy().

Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1e613f3c630c7bbc72e04a44b178259b9164d2f6.1543798395.git.sbobroff@linux.ibm.com
  • Loading branch information
Sam Bobroff authored and Dave Airlie committed Dec 6, 2018
1 parent 6ccd895 commit e594a5e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/ast/ast_fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ static void ast_fbdev_destroy(struct drm_device *dev,
{
struct ast_framebuffer *afb = &afbdev->afb;

drm_crtc_force_disable_all(dev);
drm_fb_helper_unregister_fbi(&afbdev->helper);

if (afb->obj) {
Expand Down

0 comments on commit e594a5e

Please sign in to comment.