Skip to content

Commit

Permalink
net: qede: use return from qede_flow_spec_validate_unused()
Browse files Browse the repository at this point in the history
When calling qede_flow_spec_validate_unused() then
the return code was only used for a non-zero check,
and then -EOPNOTSUPP was returned.

qede_flow_spec_validate_unused() can currently fail with:
* -EOPNOTSUPP

This patch changes qede_flow_spec_to_rule() to use the
actual return code from qede_flow_spec_validate_unused(),
so it's no longer assumed that all errors are -EOPNOTSUPP.

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  • Loading branch information
Asbjørn Sloth Tønnesen authored and Paolo Abeni committed May 7, 2024
1 parent 146817e commit e5ed2f0
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/net/ethernet/qlogic/qede/qede_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1979,10 +1979,11 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
struct ethtool_rx_flow_spec_input input = {};
struct ethtool_rx_flow_rule *flow;
__be16 proto;
int err = 0;
int err;

if (qede_flow_spec_validate_unused(edev, fs))
return -EOPNOTSUPP;
err = qede_flow_spec_validate_unused(edev, fs);
if (err)
return err;

switch ((fs->flow_type & ~FLOW_EXT)) {
case TCP_V4_FLOW:
Expand Down

0 comments on commit e5ed2f0

Please sign in to comment.