Skip to content

Commit

Permalink
kbuild: print only total number of section mismatces found
Browse files Browse the repository at this point in the history
We have too many section mismatches detected at the moment.
So silence modpost and prevent the option from being
set in a typical allyesconfig build.

Tell the user how to see all the deteils in the summary
message from modpost.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
Sam Ravnborg committed Feb 3, 2008
1 parent 9135f19 commit e5f95c8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion lib/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ config HEADERS_CHECK

config DEBUG_SECTION_MISMATCH
bool "Enable full Section mismatch analysis"
default n
depends on UNDEFINED
help
The section mismatch analysis checks if there are illegal
references from one section to another section.
Expand Down
15 changes: 7 additions & 8 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -1125,15 +1125,15 @@ static void report_sec_mismatch(const char *modname, enum mismatch mismatch,
to = to_is_func ? "function" : "variable";
to_p = to_is_func ? "()" : "";

sec_mismatch_count++;
if (!sec_mismatch_verbose)
return;

fprintf(stderr, "WARNING: %s(%s+0x%llx): Section mismatch in"
" reference from the %s %s%s to the %s %s:%s%s\n",
modname, fromsec, fromaddr, from, fromsym, from_p,
to, tosec, tosym, to_p);

sec_mismatch_count++;
if (!sec_mismatch_verbose)
return;

switch (mismatch) {
case TEXT_TO_INIT:
fprintf(stderr,
Expand Down Expand Up @@ -1939,10 +1939,9 @@ int main(int argc, char **argv)
write_dump(dump_write);
if (sec_mismatch_count && !sec_mismatch_verbose)
fprintf(stderr, "modpost: Found %d section mismatch(es).\n"
"To see additional details select \"Enable full "
"Section mismatch analysis\"\n"
"in the Kernel Hacking menu "
"(CONFIG_SECTION_MISMATCH).\n", sec_mismatch_count);
"To see full details build your kernel with:\n"
"'make CONFIG_DEBUG_SECTION_MISMATCH=y'\n",
sec_mismatch_count);

return err;
}

0 comments on commit e5f95c8

Please sign in to comment.