Skip to content

Commit

Permalink
Merge tag 'spi-fix-v6.15-rc1' of git://git.kernel.org/pub/scm/linux/k…
Browse files Browse the repository at this point in the history
…ernel/git/broonie/spi

Pull spi fixes from Mark Brown:
 "A couple of cleanups for the error handling in the Freescale drivers"

* tag 'spi-fix-v6.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
  spi: fsl-spi: Remove redundant probe error message
  spi: fsl-qspi: Fix double cleanup in probe error path
  • Loading branch information
Linus Torvalds committed Apr 11, 2025
2 parents 2f3e5ef + 82bedbf commit e618ee8
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/spi/spi-fsl-qspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -949,24 +949,20 @@ static int fsl_qspi_probe(struct platform_device *pdev)

ret = devm_add_action_or_reset(dev, fsl_qspi_cleanup, q);
if (ret)
goto err_destroy_mutex;
goto err_put_ctrl;

ret = devm_spi_register_controller(dev, ctlr);
if (ret)
goto err_destroy_mutex;
goto err_put_ctrl;

return 0;

err_destroy_mutex:
mutex_destroy(&q->lock);

err_disable_clk:
fsl_qspi_clk_disable_unprep(q);

err_put_ctrl:
spi_controller_put(ctlr);

dev_err(dev, "Freescale QuadSPI probe failed\n");
return ret;
}

Expand Down

0 comments on commit e618ee8

Please sign in to comment.