Skip to content

Commit

Permalink
powerpc/uaccess: Switch __patch_instruction() to __put_user_asm_goto()
Browse files Browse the repository at this point in the history
__patch_instruction() is the only user of __put_user_asm() outside
of asm/uaccess.h

Switch to the new __put_user_asm_goto() to enable retirement of
__put_user_asm() in a later patch.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/b9745b122f4a9ae72cef445c61320022ab8b77b7.1599216721.git.christophe.leroy@csgroup.eu
  • Loading branch information
Christophe Leroy authored and Michael Ellerman committed Sep 15, 2020
1 parent ee0a49a commit e64ac41
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions arch/powerpc/lib/code-patching.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,18 @@
static int __patch_instruction(struct ppc_inst *exec_addr, struct ppc_inst instr,
struct ppc_inst *patch_addr)
{
int err = 0;

if (!ppc_inst_prefixed(instr)) {
__put_user_asm(ppc_inst_val(instr), patch_addr, err, "stw");
} else {
__put_user_asm(ppc_inst_as_u64(instr), patch_addr, err, "std");
}

if (err)
return err;
if (!ppc_inst_prefixed(instr))
__put_user_asm_goto(ppc_inst_val(instr), patch_addr, failed, "stw");
else
__put_user_asm_goto(ppc_inst_as_u64(instr), patch_addr, failed, "std");

asm ("dcbst 0, %0; sync; icbi 0,%1; sync; isync" :: "r" (patch_addr),
"r" (exec_addr));

return 0;

failed:
return -EFAULT;
}

int raw_patch_instruction(struct ppc_inst *addr, struct ppc_inst instr)
Expand Down

0 comments on commit e64ac41

Please sign in to comment.