Skip to content

Commit

Permalink
netdevsim: convert to DEFINE_SHOW_ATTRIBUTE
Browse files Browse the repository at this point in the history
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yangtao Li authored and David S. Miller committed Dec 13, 2018
1 parent 9a58ee2 commit e6652f0
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions drivers/net/netdevsim/bpf.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ struct nsim_bpf_bound_map {
struct list_head l;
};

static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data)
static int nsim_bpf_string_show(struct seq_file *file, void *data)
{
const char **str = file->private;

Expand All @@ -57,19 +57,7 @@ static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data)

return 0;
}

static int nsim_debugfs_bpf_string_open(struct inode *inode, struct file *f)
{
return single_open(f, nsim_debugfs_bpf_string_read, inode->i_private);
}

static const struct file_operations nsim_bpf_string_fops = {
.owner = THIS_MODULE,
.open = nsim_debugfs_bpf_string_open,
.release = single_release,
.read = seq_read,
.llseek = seq_lseek
};
DEFINE_SHOW_ATTRIBUTE(nsim_bpf_string);

static int
nsim_bpf_verify_insn(struct bpf_verifier_env *env, int insn_idx, int prev_insn)
Expand Down

0 comments on commit e6652f0

Please sign in to comment.