Skip to content

Commit

Permalink
Bluetooth: ISO: Fix CIG auto-allocation to select configurable CIG
Browse files Browse the repository at this point in the history
Make CIG auto-allocation to select the first CIG_ID that is still
configurable. Also use correct CIG_ID range (see Core v5.3 Vol 4 Part E
Sec 7.8.97 p.2553).

Previously, it would always select CIG_ID 0 regardless of anything,
because cis_list with data.cis == 0xff (BT_ISO_QOS_CIS_UNSET) would not
count any CIS. Since we are not adding CIS here, use find_cis instead.

Fixes: 26afbd8 ("Bluetooth: Add initial implementation of CIS connections")
Signed-off-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  • Loading branch information
Pauli Virtanen authored and Luiz Augusto von Dentz committed Jun 6, 2023
1 parent 31c5f91 commit e6a7a46
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions net/bluetooth/hci_conn.c
Original file line number Diff line number Diff line change
Expand Up @@ -1769,24 +1769,23 @@ static bool hci_le_set_cig_params(struct hci_conn *conn, struct bt_iso_qos *qos)

memset(&data, 0, sizeof(data));

/* Allocate a CIG if not set */
/* Allocate first still reconfigurable CIG if not set */
if (qos->ucast.cig == BT_ISO_QOS_CIG_UNSET) {
for (data.cig = 0x00; data.cig < 0xff; data.cig++) {
for (data.cig = 0x00; data.cig < 0xf0; data.cig++) {
data.count = 0;
data.cis = 0xff;

hci_conn_hash_list_state(hdev, cis_list, ISO_LINK,
BT_BOUND, &data);
hci_conn_hash_list_state(hdev, find_cis, ISO_LINK,
BT_CONNECT, &data);
if (data.count)
continue;

hci_conn_hash_list_state(hdev, cis_list, ISO_LINK,
hci_conn_hash_list_state(hdev, find_cis, ISO_LINK,
BT_CONNECTED, &data);
if (!data.count)
break;
}

if (data.cig == 0xff)
if (data.cig == 0xf0)
return false;

/* Update CIG */
Expand Down

0 comments on commit e6a7a46

Please sign in to comment.