Skip to content

Commit

Permalink
lpfc_debugfs: get rid of pointless access_ok()
Browse files Browse the repository at this point in the history
	No, you do NOT need to "protect copy from user" that way.
Incidentally, your userland ABI stinks.  I understand that you
wanted to accept "reset" and "reset\n" as equivalent, but I suspect
that accepting "reset this, you !@^!@!" had been an accident.
Nothing to do about that now - it is a userland ABI...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed May 29, 2020
1 parent d2659e5 commit e6c0433
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions drivers/scsi/lpfc/lpfc_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2166,10 +2166,6 @@ lpfc_debugfs_lockstat_write(struct file *file, const char __user *buf,
char *pbuf;
int i;

/* Protect copy from user */
if (!access_ok(buf, nbytes))
return -EFAULT;

memset(mybuf, 0, sizeof(mybuf));

if (copy_from_user(mybuf, buf, nbytes))
Expand Down Expand Up @@ -2621,10 +2617,6 @@ lpfc_debugfs_multixripools_write(struct file *file, const char __user *buf,
if (nbytes > 64)
nbytes = 64;

/* Protect copy from user */
if (!access_ok(buf, nbytes))
return -EFAULT;

memset(mybuf, 0, sizeof(mybuf));

if (copy_from_user(mybuf, buf, nbytes))
Expand Down Expand Up @@ -2787,10 +2779,6 @@ lpfc_debugfs_scsistat_write(struct file *file, const char __user *buf,
char mybuf[6] = {0};
int i;

/* Protect copy from user */
if (!access_ok(buf, nbytes))
return -EFAULT;

if (copy_from_user(mybuf, buf, (nbytes >= sizeof(mybuf)) ?
(sizeof(mybuf) - 1) : nbytes))
return -EFAULT;
Expand Down

0 comments on commit e6c0433

Please sign in to comment.