Skip to content

Commit

Permalink
can: flexcan: using pm_runtime_resume_and_get instead of pm_runtime_g…
Browse files Browse the repository at this point in the history
…et_sync

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Link: https://lore.kernel.org/all/20220419081449.2574026-1-chi.minghao@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Minghao Chi authored and Marc Kleine-Budde committed Apr 19, 2022
1 parent bb75e35 commit e6ec837
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/net/can/flexcan/flexcan-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -723,11 +723,9 @@ static int flexcan_get_berr_counter(const struct net_device *dev,
const struct flexcan_priv *priv = netdev_priv(dev);
int err;

err = pm_runtime_get_sync(priv->dev);
if (err < 0) {
pm_runtime_put_noidle(priv->dev);
err = pm_runtime_resume_and_get(priv->dev);
if (err < 0)
return err;
}

err = __flexcan_get_berr_counter(dev, bec);

Expand Down Expand Up @@ -1700,11 +1698,9 @@ static int flexcan_open(struct net_device *dev)
return -EINVAL;
}

err = pm_runtime_get_sync(priv->dev);
if (err < 0) {
pm_runtime_put_noidle(priv->dev);
err = pm_runtime_resume_and_get(priv->dev);
if (err < 0)
return err;
}

err = open_candev(dev);
if (err)
Expand Down

0 comments on commit e6ec837

Please sign in to comment.