Skip to content

Commit

Permalink
crypto: cavium - Fix smp_processor_id() warnings
Browse files Browse the repository at this point in the history
Switch to raw_smp_processor_id() to prevent a number of
warnings from kernel debugging. We do not care about
preemption here, as the CPU number is only used as a
poor mans load balancing or device selection. If preemption
happens during a compress/decompress operation a small performance
hit will occur but everything will continue to work, so just
ignore it.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
Reviewed-by: Robert Richter <rrichter@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Jan Glauber authored and Herbert Xu committed Apr 20, 2018
1 parent 1cc7e01 commit e7a9b05
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/crypto/cavium/zip/zip_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ u32 zip_load_instr(union zip_inst_s *instr,
* Distribute the instructions between the enabled queues based on
* the CPU id.
*/
if (smp_processor_id() % 2 == 0)
if (raw_smp_processor_id() % 2 == 0)
queue = 0;
else
queue = 1;

zip_dbg("CPU Core: %d Queue number:%d", smp_processor_id(), queue);
zip_dbg("CPU Core: %d Queue number:%d", raw_smp_processor_id(), queue);

/* Take cmd buffer lock */
spin_lock(&zip_dev->iq[queue].lock);
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cavium/zip/zip_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ struct zip_device *zip_get_device(int node)
*/
int zip_get_node_id(void)
{
return cpu_to_node(smp_processor_id());
return cpu_to_node(raw_smp_processor_id());
}

/* Initializes the ZIP h/w sub-system */
Expand Down

0 comments on commit e7a9b05

Please sign in to comment.