Skip to content

Commit

Permalink
dt-bindings: i2c: migrate mt7621 text bindings to YAML
Browse files Browse the repository at this point in the history
SoC MT7621 I2C bindings used text format, so migrate them to YAML.
There are some additions to the binding that were not in the original
txt file. This binding is used in MT7621 and MT7628a Ralink SoCs. To
properly match both dts nodes in tree we need to add to the schema
'clocks', 'clock-names' and 'reset-names'. Both 'clock-names' and
'reset-names' use 'i2c' as string so maintain that as const in
the schema. Also, Properly update MAINTAINERS file to align the
changes.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220920052050.582321-1-sergio.paracuellos@gmail.com
Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
Sergio Paracuellos authored and Rob Herring committed Sep 26, 2022
1 parent 6d83bcf commit e7c2194
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 26 deletions.
25 changes: 0 additions & 25 deletions Documentation/devicetree/bindings/i2c/i2c-mt7621.txt

This file was deleted.

61 changes: 61 additions & 0 deletions Documentation/devicetree/bindings/i2c/mediatek,mt7621-i2c.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/i2c/mediatek,mt7621-i2c.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

maintainers:
- Stefan Roese <sr@denx.de>

title: Mediatek MT7621/MT7628 I2C master controller

allOf:
- $ref: /schemas/i2c/i2c-controller.yaml#

properties:
compatible:
const: mediatek,mt7621-i2c

reg:
maxItems: 1

clocks:
maxItems: 1

clock-names:
const: i2c

resets:
maxItems: 1

reset-names:
const: i2c

required:
- compatible
- reg
- resets
- "#address-cells"
- "#size-cells"

unevaluatedProperties: false

examples:
- |
#include <dt-bindings/clock/mt7621-clk.h>
#include <dt-bindings/reset/mt7621-reset.h>
i2c: i2c@900 {
compatible = "mediatek,mt7621-i2c";
reg = <0x900 0x100>;
clocks = <&sysc MT7621_CLK_I2C>;
clock-names = "i2c";
resets = <&sysc MT7621_RST_I2C>;
reset-names = "i2c";
#address-cells = <1>;
#size-cells = <0>;
pinctrl-names = "default";
pinctrl-0 = <&i2c_pins>;
};
2 changes: 1 addition & 1 deletion MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -12865,7 +12865,7 @@ MEDIATEK MT7621/28/88 I2C DRIVER
M: Stefan Roese <sr@denx.de>
L: linux-i2c@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/i2c/i2c-mt7621.txt
F: Documentation/devicetree/bindings/i2c/mediatek,mt7621-i2c.yaml
F: drivers/i2c/busses/i2c-mt7621.c

MEDIATEK MT7621 PCIE CONTROLLER DRIVER
Expand Down

0 comments on commit e7c2194

Please sign in to comment.