Skip to content

Commit

Permalink
xfrm: add SA information to the offloaded packet
Browse files Browse the repository at this point in the history
In packet offload mode, append Security Association (SA) information
to each packet, replicating the crypto offload implementation.
The XFRM_XMIT flag is set to enable packet to be returned immediately
from the validate_xmit_xfrm function, thus aligning with the existing
code path for packet offload mode.

This SA info helps HW offload match packets to their correct security
policies. The XFRM interface ID is included, which is crucial in setups
with multiple XFRM interfaces where source/destination addresses alone
can't pinpoint the right policy.

Signed-off-by: wangfe <wangfe@google.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
  • Loading branch information
wangfe authored and Steffen Klassert committed Aug 27, 2024
1 parent 5ce90c8 commit e7cd191
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions net/xfrm/xfrm_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,8 @@ int xfrm_output(struct sock *sk, struct sk_buff *skb)
struct xfrm_state *x = skb_dst(skb)->xfrm;
int family;
int err;
struct xfrm_offload *xo;
struct sec_path *sp;

family = (x->xso.type != XFRM_DEV_OFFLOAD_PACKET) ? x->outer_mode.family
: skb_dst(skb)->ops->family;
Expand All @@ -728,6 +730,25 @@ int xfrm_output(struct sock *sk, struct sk_buff *skb)
kfree_skb(skb);
return -EHOSTUNREACH;
}
sp = secpath_set(skb);
if (!sp) {
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTERROR);
kfree_skb(skb);
return -ENOMEM;
}

sp->olen++;
sp->xvec[sp->len++] = x;
xfrm_state_hold(x);

xo = xfrm_offload(skb);
if (!xo) {
secpath_reset(skb);
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTERROR);
kfree_skb(skb);
return -EINVAL;
}
xo->flags |= XFRM_XMIT;

return xfrm_output_resume(sk, skb, 0);
}
Expand Down

0 comments on commit e7cd191

Please sign in to comment.