Skip to content

Commit

Permalink
Drivers: hv: vmbus: Prevent sending data on a rescinded channel
Browse files Browse the repository at this point in the history
After the channel is rescinded, the host does not read from the rescinded channel.
Fail writes to a channel that has already been rescinded. If we permit writes on a
rescinded channel, since the host will not respond we will have situations where
we will be unable to unload vmbus drivers that cannot have any outstanding requests
to the host at the point they are unoaded.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Jan 10, 2017
1 parent 56ef671 commit e7e97dd
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/hv/ring_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ int hv_ringbuffer_write(struct vmbus_channel *channel,
unsigned long flags = 0;
struct hv_ring_buffer_info *outring_info = &channel->outbound;

if (channel->rescind)
return -ENODEV;

for (i = 0; i < kv_count; i++)
totalbytes_towrite += kv_list[i].iov_len;

Expand Down Expand Up @@ -350,6 +353,10 @@ int hv_ringbuffer_write(struct vmbus_channel *channel,
spin_unlock_irqrestore(&outring_info->ring_lock, flags);

hv_signal_on_write(old_write, channel, kick_q);

if (channel->rescind)
return -ENODEV;

return 0;
}

Expand Down

0 comments on commit e7e97dd

Please sign in to comment.