Skip to content

Commit

Permalink
tile: fix "odd fault" warning for stack backtraces
Browse files Browse the repository at this point in the history
We were setting ex1 in new kernel threads to KERNEL_PL.
But since we just do a simple context-switch, not an iret,
any value set here is ignored anyway, and its presence causes
stack backtraces to end with a warning about an "odd fault".

Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
  • Loading branch information
Chris Metcalf committed May 11, 2015
1 parent 9a5d2cb commit e8200ba
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/tile/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ int copy_thread(unsigned long clone_flags, unsigned long sp,
(CALLEE_SAVED_REGS_COUNT - 2) * sizeof(unsigned long));
callee_regs[0] = sp; /* r30 = function */
callee_regs[1] = arg; /* r31 = arg */
childregs->ex1 = PL_ICS_EX1(KERNEL_PL, 0);
p->thread.pc = (unsigned long) ret_from_kernel_thread;
return 0;
}
Expand Down

0 comments on commit e8200ba

Please sign in to comment.