Skip to content

Commit

Permalink
virtio_ring: fix num_free handling in error case
Browse files Browse the repository at this point in the history
The vq->vq.num_free hasn't been changed when error happens,
so it shouldn't be changed when handling the error.

Fixes: 780bc79 ("virtio_ring: Support DMA APIs")
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
Tiwei Bie authored and Michael S. Tsirkin committed Mar 1, 2018
1 parent 4a3928c commit e82df67
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/virtio/virtio_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,6 @@ static inline int virtqueue_add(struct virtqueue *_vq,
i = virtio16_to_cpu(_vq->vdev, vq->vring.desc[i].next);
}

vq->vq.num_free += total_sg;

if (indirect)
kfree(desc);

Expand Down

0 comments on commit e82df67

Please sign in to comment.