Skip to content

Commit

Permalink
net: ethernet: mediatek: fix missing changes merged for conflicts ove…
Browse files Browse the repository at this point in the history
…rlapping commits

add the missing commits about
1)
Commit d3bd1ce
("remove redundant free_irq for devm_request_ir allocated irq")
2)
Commit 7c6b0d7
("fix logic unbalance between probe and remove")

during merge for conflicts overlapping commits by
Commit b20b378
("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sean Wang authored and David S. Miller committed Sep 22, 2016
1 parent f9d1846 commit e82f714
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/ethernet/mediatek/mtk_eth_soc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1894,11 +1894,8 @@ static void mtk_uninit(struct net_device *dev)
struct mtk_eth *eth = mac->hw;

phy_disconnect(mac->phy_dev);
mtk_mdio_cleanup(eth);
mtk_irq_disable(eth, MTK_QDMA_INT_MASK, ~0);
mtk_irq_disable(eth, MTK_PDMA_INT_MASK, ~0);
free_irq(eth->irq[1], dev);
free_irq(eth->irq[2], dev);
}

static int mtk_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
Expand Down Expand Up @@ -2454,6 +2451,7 @@ static int mtk_remove(struct platform_device *pdev)
netif_napi_del(&eth->tx_napi);
netif_napi_del(&eth->rx_napi);
mtk_cleanup(eth);
mtk_mdio_cleanup(eth);

return 0;
}
Expand Down

0 comments on commit e82f714

Please sign in to comment.