Skip to content

Commit

Permalink
PCI: Use res->parent to check if resource is assigned
Browse files Browse the repository at this point in the history
reassign_resources_sorted() uses resource_size() to select between
pci_assign_resource() and pci_reassign_resource(). Due to twisted way
bridge window sizing in pbus_size_mem() sets resource sizes to 0, it works
to match into IOV resources but that is going to be changed by an upcoming
change.

Replace resource_size() check with res->parent check that is the true
dividing line in between whether assign or reassign function should be used
for the resource.

Link: https://lore.kernel.org/r/20241216175632.4175-24-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Xiaochun Lee <lixc17@lenovo.com>
  • Loading branch information
Ilpo Järvinen authored and Bjorn Helgaas committed Feb 18, 2025
1 parent 8884b56 commit e89df6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/setup-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ static void reassign_resources_sorted(struct list_head *realloc_head,
res_name = pci_resource_name(dev, idx);
add_size = add_res->add_size;
align = add_res->min_align;
if (!resource_size(res)) {
if (!res->parent) {
resource_set_range(res, align, add_size);
if (pci_assign_resource(dev, idx)) {
pci_dbg(dev,
Expand Down

0 comments on commit e89df6d

Please sign in to comment.