Skip to content

Commit

Permalink
net: mvneta: Prevent out of bounds read in mvneta_config_rss()
Browse files Browse the repository at this point in the history
The pp->indir[0] value comes from the user.  It is passed to:

	if (cpu_online(pp->rxq_def))

inside the mvneta_percpu_elect() function.  It needs bounds checkeding
to ensure that it is not beyond the end of the cpu bitmap.

Fixes: cad5d84 ("net: mvneta: Fix the CPU choice in mvneta_percpu_elect")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Dec 5, 2022
1 parent d50b791 commit e8b4fc1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/marvell/mvneta.c
Original file line number Diff line number Diff line change
Expand Up @@ -4927,6 +4927,9 @@ static int mvneta_config_rss(struct mvneta_port *pp)
napi_disable(&pp->napi);
}

if (pp->indir[0] >= nr_cpu_ids)
return -EINVAL;

pp->rxq_def = pp->indir[0];

/* Update unicast mapping */
Expand Down

0 comments on commit e8b4fc1

Please sign in to comment.