Skip to content

Commit

Permalink
selftests: hid: fix typo and exit code
Browse files Browse the repository at this point in the history
The correct exit code to mark a test as skipped is 4.

Fixes: ffb85d5 ("selftests: hid: import hid-tools hid-core tests")
Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
Link: https://patch.msgid.link/20241126135850.76493-1-mheyne@amazon.de
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
  • Loading branch information
Maximilian Heyne authored and Benjamin Tissoires committed Nov 28, 2024
1 parent 5954821 commit e8f3474
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions tools/testing/selftests/hid/run-hid-tools-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,26 @@
# SPDX-License-Identifier: GPL-2.0
# Runs tests for the HID subsystem

KSELFTEST_SKIP_TEST=4

if ! command -v python3 > /dev/null 2>&1; then
echo "hid-tools: [SKIP] python3 not installed"
exit 77
exit $KSELFTEST_SKIP_TEST
fi

if ! python3 -c "import pytest" > /dev/null 2>&1; then
echo "hid: [SKIP/ pytest module not installed"
exit 77
echo "hid: [SKIP] pytest module not installed"
exit $KSELFTEST_SKIP_TEST
fi

if ! python3 -c "import pytest_tap" > /dev/null 2>&1; then
echo "hid: [SKIP/ pytest_tap module not installed"
exit 77
echo "hid: [SKIP] pytest_tap module not installed"
exit $KSELFTEST_SKIP_TEST
fi

if ! python3 -c "import hidtools" > /dev/null 2>&1; then
echo "hid: [SKIP/ hid-tools module not installed"
exit 77
echo "hid: [SKIP] hid-tools module not installed"
exit $KSELFTEST_SKIP_TEST
fi

TARGET=${TARGET:=.}
Expand Down

0 comments on commit e8f3474

Please sign in to comment.