Skip to content

Commit

Permalink
spi: armada-3700: Remove spi_master_put in a3700_spi_remove()
Browse files Browse the repository at this point in the history
The call to spi_master_put() in a3700_spi_remove() is redundant since
the master is registered using devm_spi_register_master() and no
reference hold by using spi_master_get() in a3700_spi_remove().

This is detected by Coccinelle semantic patch.

Fixes: 5762ab7 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Feb 19, 2017
1 parent d9928b4 commit e92f005
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/spi/spi-armada-3700.c
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,6 @@ static int a3700_spi_remove(struct platform_device *pdev)
struct a3700_spi *spi = spi_master_get_devdata(master);

clk_unprepare(spi->clk);
spi_master_put(master);

return 0;
}
Expand Down

0 comments on commit e92f005

Please sign in to comment.