Skip to content

Commit

Permalink
powerpc/test_emulate_step: Move extern declaration to sstep.h
Browse files Browse the repository at this point in the history
fix checkpatch.pl warnings by moving extern declaration from source
file to headerfile.

Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200626095158.1031507-5-bala24@linux.ibm.com
  • Loading branch information
Balamuruhan S authored and Michael Ellerman committed Jul 23, 2020
1 parent 68a180a commit e93ad65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions arch/powerpc/include/asm/sstep.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ enum instruction_type {
#define GET_PREFIX_RA(i) (((i) >> 16) & 0x1f)
#define GET_PREFIX_R(i) ((i) & (1ul << 20))

extern s32 patch__exec_instr;

struct instruction_op {
int type;
int reg;
Expand Down
2 changes: 0 additions & 2 deletions arch/powerpc/lib/test_emulate_step.c
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,6 @@ static int __init emulate_compute_instr(struct pt_regs *regs,
bool negative)
{
int analysed;
extern s32 patch__exec_instr;
struct instruction_op op;

if (!regs || !ppc_inst_val(instr))
Expand All @@ -1176,7 +1175,6 @@ static int __init execute_compute_instr(struct pt_regs *regs,
struct ppc_inst instr)
{
extern int exec_instr(struct pt_regs *regs);
extern s32 patch__exec_instr;

if (!regs || !ppc_inst_val(instr))
return -EINVAL;
Expand Down

0 comments on commit e93ad65

Please sign in to comment.