Skip to content

Commit

Permalink
pinctrl: intel: refine ->set_mux() hook
Browse files Browse the repository at this point in the history
Utilize a temporary variable for common shift operation in
->set_mux() hook and improve readability while saving a few bytes.

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
Function                                     old     new   delta
intel_pinmux_set_mux                         245     242      -3
Total: Before=10472, After=10469, chg -0.03%

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20230613085054.10976-2-raag.jadav@intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  • Loading branch information
Raag Jadav authored and Andy Shevchenko committed Jun 14, 2023
1 parent c518d31 commit e95433c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/pinctrl/intel/pinctrl-intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev,
/* Now enable the mux setting for each pin in the group */
for (i = 0; i < grp->grp.npins; i++) {
void __iomem *padcfg0;
u32 value;
u32 value, pmode;

padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0);
value = readl(padcfg0);

value = readl(padcfg0);
value &= ~PADCFG0_PMODE_MASK;

if (grp->modes)
value |= grp->modes[i] << PADCFG0_PMODE_SHIFT;
pmode = grp->modes[i];
else
value |= grp->mode << PADCFG0_PMODE_SHIFT;
pmode = grp->mode;

value |= pmode << PADCFG0_PMODE_SHIFT;
writel(value, padcfg0);
}

Expand Down

0 comments on commit e95433c

Please sign in to comment.