Skip to content

Commit

Permalink
wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration
Browse files Browse the repository at this point in the history
Found by comparing with the vendor driver. Currently this affects
only the RTL8192EU, which is the only gen2 chip with 2 TX paths
supported by this driver. It's unclear what kind of effect the
mistake had in practice, since I don't have any RTL8192EU devices
to test it.

Fixes: e1547c5 ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts")
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com
  • Loading branch information
Bitterblue Smith authored and Kalle Valo committed Sep 12, 2022
1 parent bd1056d commit e963a19
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2929,12 +2929,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv,
}

if (!(simubitmap & 0x30) && priv->tx_paths > 1) {
/* path B RX OK */
/* path B TX OK */
for (i = 4; i < 6; i++)
result[3][i] = result[c1][i];
}

if (!(simubitmap & 0x30) && priv->tx_paths > 1) {
if (!(simubitmap & 0xc0) && priv->tx_paths > 1) {
/* path B RX OK */
for (i = 6; i < 8; i++)
result[3][i] = result[c1][i];
Expand Down

0 comments on commit e963a19

Please sign in to comment.