Skip to content

Commit

Permalink
tty: Fix hangup race with TIOCSETD ioctl
Browse files Browse the repository at this point in the history
The hangup may already have happened; check for that state also.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Hurley authored and Greg Kroah-Hartman committed Jul 23, 2013
1 parent 9fbfa34 commit e97733c
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/tty/tty_ldisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,10 +546,8 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
old_ldisc = tty->ldisc;
tty_lock(tty);

/* FIXME: for testing only */
WARN_ON(test_bit(TTY_HUPPED, &tty->flags));

if (test_bit(TTY_HUPPING, &tty->flags)) {
if (test_bit(TTY_HUPPING, &tty->flags) ||
test_bit(TTY_HUPPED, &tty->flags)) {
/* We were raced by the hangup method. It will have stomped
the ldisc data and closed the ldisc down */
tty_ldisc_enable_pair(tty, o_tty);
Expand Down

0 comments on commit e97733c

Please sign in to comment.