Skip to content

Commit

Permalink
net: hns3: replace disable_irq by IRQ_NOAUTOEN flag
Browse files Browse the repository at this point in the history
disable_irq() after request_irq() is still risk as there is a chance irq
can come after request_irq() and before disable_irq().
this should be done by IRQ_NOAUTOEN flag.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Barry Song authored and David S. Miller committed Jun 19, 2020
1 parent 4d2cad3 commit e99a308
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <linux/cpu_rmap.h>
#endif
#include <linux/if_vlan.h>
#include <linux/irq.h>
#include <linux/ip.h>
#include <linux/ipv6.h>
#include <linux/module.h>
Expand Down Expand Up @@ -154,6 +155,7 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)

tqp_vectors->name[HNAE3_INT_NAME_LEN - 1] = '\0';

irq_set_status_flags(tqp_vectors->vector_irq, IRQ_NOAUTOEN);
ret = request_irq(tqp_vectors->vector_irq, hns3_irq_handle, 0,
tqp_vectors->name, tqp_vectors);
if (ret) {
Expand All @@ -163,8 +165,6 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)
return ret;
}

disable_irq(tqp_vectors->vector_irq);

irq_set_affinity_hint(tqp_vectors->vector_irq,
&tqp_vectors->affinity_mask);

Expand Down

0 comments on commit e99a308

Please sign in to comment.