Skip to content

Commit

Permalink
mmc: sdhci: Move some processing to __sdhci_finish_mrq()
Browse files Browse the repository at this point in the history
In preparation for removing finish_tasklet, move some processing from
sdhci_request_done() to __sdhci_finish_mrq().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Adrian Hunter authored and Ulf Hansson committed Apr 15, 2019
1 parent 97a1aba commit e9a0729
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/mmc/host/sdhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,11 @@ static void __sdhci_finish_mrq(struct sdhci_host *host, struct mmc_request *mrq)
}

WARN_ON(i >= SDHCI_MAX_MRQS);

sdhci_del_timer(host, mrq);

if (!sdhci_has_requests(host))
sdhci_led_deactivate(host);
}

static void sdhci_finish_mrq(struct sdhci_host *host, struct mmc_request *mrq)
Expand Down Expand Up @@ -2617,8 +2622,6 @@ static bool sdhci_request_done(struct sdhci_host *host)
return true;
}

sdhci_del_timer(host, mrq);

/*
* Always unmap the data buffers if they were mapped by
* sdhci_prepare_data() whenever we finish with a request.
Expand Down Expand Up @@ -2700,9 +2703,6 @@ static bool sdhci_request_done(struct sdhci_host *host)
host->pending_reset = false;
}

if (!sdhci_has_requests(host))
sdhci_led_deactivate(host);

host->mrqs_done[i] = NULL;

mmiowb();
Expand Down

0 comments on commit e9a0729

Please sign in to comment.