Skip to content

Commit

Permalink
net_sched: sch_fq: remove one obsolete check in fq_dequeue()
Browse files Browse the repository at this point in the history
After commit eeb84aa ("net_sched: sch_fq: do not assume EDT
packets are ordered"), all skbs get a non zero time_to_send
in flow_queue_add()

This means @time_next_packet variable in fq_dequeue()
can no longer be zero.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Oct 16, 2019
1 parent 6570bc7 commit e9c43ad
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/sched/sch_fq.c
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,7 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch)
fq_flow_set_throttled(q, f);
goto begin;
}
if (time_next_packet &&
(s64)(now - time_next_packet - q->ce_threshold) > 0) {
if ((s64)(now - time_next_packet - q->ce_threshold) > 0) {
INET_ECN_set_ce(skb);
q->stat_ce_mark++;
}
Expand Down

0 comments on commit e9c43ad

Please sign in to comment.