Skip to content

Commit

Permalink
power: ab8500: convert to use match_string() helper
Browse files Browse the repository at this point in the history
The new helper returns index of the mathing string in an array.  We
would use it here.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andy Shevchenko authored and Linus Torvalds committed Mar 17, 2016
1 parent 5f47682 commit ea32cea
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 40 deletions.
15 changes: 5 additions & 10 deletions drivers/power/ab8500_btemp.c
Original file line number Diff line number Diff line change
Expand Up @@ -906,26 +906,21 @@ static int ab8500_btemp_get_property(struct power_supply *psy,
static int ab8500_btemp_get_ext_psy_data(struct device *dev, void *data)
{
struct power_supply *psy;
struct power_supply *ext;
struct power_supply *ext = dev_get_drvdata(dev);
const char **supplicants = (const char **)ext->supplied_to;
struct ab8500_btemp *di;
union power_supply_propval ret;
int i, j;
bool psy_found = false;
int j;

psy = (struct power_supply *)data;
ext = dev_get_drvdata(dev);
di = power_supply_get_drvdata(psy);

/*
* For all psy where the name of your driver
* appears in any supplied_to
*/
for (i = 0; i < ext->num_supplicants; i++) {
if (!strcmp(ext->supplied_to[i], psy->desc->name))
psy_found = true;
}

if (!psy_found)
j = match_string(supplicants, ext->num_supplicants, psy->desc->name);
if (j < 0)
return 0;

/* Go through all properties for the psy */
Expand Down
16 changes: 5 additions & 11 deletions drivers/power/ab8500_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1929,27 +1929,21 @@ static int ab8540_charger_usb_pre_chg_enable(struct ux500_charger *charger,
static int ab8500_charger_get_ext_psy_data(struct device *dev, void *data)
{
struct power_supply *psy;
struct power_supply *ext;
struct power_supply *ext = dev_get_drvdata(dev);
const char **supplicants = (const char **)ext->supplied_to;
struct ab8500_charger *di;
union power_supply_propval ret;
int i, j;
bool psy_found = false;
int j;
struct ux500_charger *usb_chg;

usb_chg = (struct ux500_charger *)data;
psy = usb_chg->psy;

di = to_ab8500_charger_usb_device_info(usb_chg);

ext = dev_get_drvdata(dev);

/* For all psy where the driver name appears in any supplied_to */
for (i = 0; i < ext->num_supplicants; i++) {
if (!strcmp(ext->supplied_to[i], psy->desc->name))
psy_found = true;
}

if (!psy_found)
j = match_string(supplicants, ext->num_supplicants, psy->desc->name);
if (j < 0)
return 0;

/* Go through all properties for the psy */
Expand Down
15 changes: 5 additions & 10 deletions drivers/power/ab8500_fg.c
Original file line number Diff line number Diff line change
Expand Up @@ -2168,26 +2168,21 @@ static int ab8500_fg_get_property(struct power_supply *psy,
static int ab8500_fg_get_ext_psy_data(struct device *dev, void *data)
{
struct power_supply *psy;
struct power_supply *ext;
struct power_supply *ext = dev_get_drvdata(dev);
const char **supplicants = (const char **)ext->supplied_to;
struct ab8500_fg *di;
union power_supply_propval ret;
int i, j;
bool psy_found = false;
int j;

psy = (struct power_supply *)data;
ext = dev_get_drvdata(dev);
di = power_supply_get_drvdata(psy);

/*
* For all psy where the name of your driver
* appears in any supplied_to
*/
for (i = 0; i < ext->num_supplicants; i++) {
if (!strcmp(ext->supplied_to[i], psy->desc->name))
psy_found = true;
}

if (!psy_found)
j = match_string(supplicants, ext->num_supplicants, psy->desc->name);
if (j < 0)
return 0;

/* Go through all properties for the psy */
Expand Down
14 changes: 5 additions & 9 deletions drivers/power/abx500_chargalg.c
Original file line number Diff line number Diff line change
Expand Up @@ -975,22 +975,18 @@ static void handle_maxim_chg_curr(struct abx500_chargalg *di)
static int abx500_chargalg_get_ext_psy_data(struct device *dev, void *data)
{
struct power_supply *psy;
struct power_supply *ext;
struct power_supply *ext = dev_get_drvdata(dev);
const char **supplicants = (const char **)ext->supplied_to;
struct abx500_chargalg *di;
union power_supply_propval ret;
int i, j;
bool psy_found = false;
int j;
bool capacity_updated = false;

psy = (struct power_supply *)data;
ext = dev_get_drvdata(dev);
di = power_supply_get_drvdata(psy);
/* For all psy where the driver name appears in any supplied_to */
for (i = 0; i < ext->num_supplicants; i++) {
if (!strcmp(ext->supplied_to[i], psy->desc->name))
psy_found = true;
}
if (!psy_found)
j = match_string(supplicants, ext->num_supplicants, psy->desc->name);
if (j < 0)
return 0;

/*
Expand Down

0 comments on commit ea32cea

Please sign in to comment.