Skip to content

Commit

Permalink
ax25: add link layer header validation function
Browse files Browse the repository at this point in the history
As variable length protocol, AX25 fails link layer header validation
tests based on a minimum length. header_ops.validate allows protocols
to validate headers that are shorter than hard_header_len. Implement
this callback for AX25.

See also http://comments.gmane.org/gmane.linux.network/401064

Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Willem de Bruijn authored and David S. Miller committed Mar 10, 2016
1 parent 2793a23 commit ea47781
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions net/ax25/ax25_ip.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,23 @@ netdev_tx_t ax25_ip_xmit(struct sk_buff *skb)
}
#endif

static bool ax25_validate_header(const char *header, unsigned int len)
{
ax25_digi digi;

if (!len)
return false;

if (header[0])
return true;

return ax25_addr_parse(header + 1, len - 1, NULL, NULL, &digi, NULL,
NULL);
}

const struct header_ops ax25_header_ops = {
.create = ax25_hard_header,
.validate = ax25_validate_header,
};

EXPORT_SYMBOL(ax25_header_ops);
Expand Down

0 comments on commit ea47781

Please sign in to comment.