Skip to content

Commit

Permalink
Input: matrix_keypad - fix race when disabling interrupts
Browse files Browse the repository at this point in the history
If matrix_keypad_stop() is executing and the keypad interrupt is triggered,
disable_row_irqs() may be called by both matrix_keypad_interrupt() and
matrix_keypad_stop() at the same time, causing interrupts to be disabled
twice and the keypad being "stuck" after resuming.

Take lock when setting keypad->stopped to ensure that ISR will not race
with matrix_keypad_stop() disabling interrupts.

Signed-off-by: Zhang Bo <zbsdta@126.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Zhang Bo authored and Dmitry Torokhov committed Feb 10, 2018
1 parent 0004520 commit ea4f7bd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/input/keyboard/matrix_keypad.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,10 @@ static void matrix_keypad_stop(struct input_dev *dev)
{
struct matrix_keypad *keypad = input_get_drvdata(dev);

spin_lock_irq(&keypad->lock);
keypad->stopped = true;
mb();
spin_unlock_irq(&keypad->lock);

flush_work(&keypad->work.work);
/*
* matrix_keypad_scan() will leave IRQs enabled;
Expand Down

0 comments on commit ea4f7bd

Please sign in to comment.